Skip to content

Backport of Regen expired test certs into release/1.16.x#19478

Merged
hc-github-team-consul-core merged 1 commit intorelease/1.16.xfrom
backport/spatel/fix-expired-test-certs/violently-happy-earwig
Nov 2, 2023
Merged

Backport of Regen expired test certs into release/1.16.x#19478
hc-github-team-consul-core merged 1 commit intorelease/1.16.xfrom
backport/spatel/fix-expired-test-certs/violently-happy-earwig

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Nov 2, 2023

Backport

This PR is auto-generated from #19476 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.

Description

=== FAIL: tlsutil TestConfigurator_OutgoingInternalRPCWrapper/VerifyServerHostname_=_false (re-run 3) (0.00s)
    config_test.go:773: 
        	Error Trace:	/home/runner/work/consul/consul/tlsutil/config_test.go:773
        	Error:      	Received unexpected error:
        	            	x509: certificate has expired or is not yet valid: current time 2023-11-02T02:24:15Z is after 2023-11-01T15:17:35Z
        	Test:       	TestConfigurator_OutgoingInternalRPCWrapper/VerifyServerHostname_=_false

Testing & Reproduction steps

Test passes locally.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/fix-expired-test-certs/violently-happy-earwig branch from d8e90c0 to cd6e545 Compare November 2, 2023 15:26
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/spatel/fix-expired-test-certs/violently-happy-earwig branch from bdf5f98 to b2f2f82 Compare November 2, 2023 15:26
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul November 2, 2023 15:36 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 552424b into release/1.16.x Nov 2, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/spatel/fix-expired-test-certs/violently-happy-earwig branch November 2, 2023 15:44
mbrulatout pushed a commit to criteo-forks/consul that referenced this pull request Dec 28, 2023
@hc-github-team-consul-core @analogue
Backport of Regen expired test certs into release/1.16.x (hashicorp#1…
f3bdb7c 
…9478)

backport of commit d399654

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
mbrulatout pushed a commit to criteo-forks/consul that referenced this pull request Dec 28, 2023
@hc-github-team-consul-core @analogue @mbrulatout
Backport of Regen expired test certs into release/1.16.x (hashicorp#1…
0f375e3 
…9478)

backport of commit d399654

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
@mbrulatout mbrulatout mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@analogue analogue Awaiting requested review from analogue

Assignees

@analogue analogue

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hc-github-team-consul-core @github-team-consul-core-pr-approver @analogue