Skip to content

Backport of Fix casing in example yaml config into release/1.16.x#19407

Merged
hc-github-team-consul-core merged 1 commit intorelease/1.16.xfrom
backport/nathancoleman-patch-1/literally-exact-crappie
Oct 27, 2023
Merged

Backport of Fix casing in example yaml config into release/1.16.x#19407
hc-github-team-consul-core merged 1 commit intorelease/1.16.xfrom
backport/nathancoleman-patch-1/literally-exact-crappie

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19369 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

This page in the docs has example code that is copy-pastable; however, it has a casing error which prevents the copied code from working for Kubernetes:

error: error validating "cluster-2/exported-services.yaml": error validating data: kind not set; if you choose to ignore these errors, turn validation off with --validate=false

Testing & Reproduction steps

Copy-paste the modified examples and attempt to apply them to a Kubernetes cluster using kubectl apply -f <filename>. Verify the command completes successfully instead of returning the above error.

Links

Page containing broken example code

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner October 27, 2023 14:15
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/nathancoleman-patch-1/literally-exact-crappie branch 2 times, most recently from de421a1 to c922cd6 Compare October 27, 2023 14:15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 27, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit 54e1c9e into release/1.16.x Oct 27, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/nathancoleman-patch-1/literally-exact-crappie branch October 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants