Skip to content

Backport of Fix casing in example yaml config into release/1.15.x#19406

Merged
nathancoleman merged 1 commit intorelease/1.15.xfrom
backport/nathancoleman-patch-1/eagerly-probable-sailfish
Oct 27, 2023
Merged

Backport of Fix casing in example yaml config into release/1.15.x#19406
nathancoleman merged 1 commit intorelease/1.15.xfrom
backport/nathancoleman-patch-1/eagerly-probable-sailfish

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Oct 27, 2023

Backport

This PR is auto-generated from #19369 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

This page in the docs has example code that is copy-pastable; however, it has a casing error which prevents the copied code from working for Kubernetes:

error: error validating "cluster-2/exported-services.yaml": error validating data: kind not set; if you choose to ignore these errors, turn validation off with --validate=false

Testing & Reproduction steps

Copy-paste the modified examples and attempt to apply them to a Kubernetes cluster using kubectl apply -f <filename>. Verify the command completes successfully instead of returning the above error.

Links

Page containing broken example code

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/nathancoleman-patch-1/eagerly-probable-sailfish branch 2 times, most recently from 4a7c3f1 to a83ff94 Compare October 27, 2023 14:15
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul October 27, 2023 14:26 Inactive
@nathancoleman nathancoleman force-pushed the backport/nathancoleman-patch-1/eagerly-probable-sailfish branch from be0dc39 to 4547449 Compare October 27, 2023 18:58
@nathancoleman nathancoleman marked this pull request as ready for review October 27, 2023 18:58
@nathancoleman nathancoleman requested a review from a team as a code owner October 27, 2023 18:58
@nathancoleman nathancoleman enabled auto-merge (squash) October 27, 2023 18:59
@nathancoleman nathancoleman added the type/docs Documentation needs to be created/updated/clarified label Oct 27, 2023
@nathancoleman nathancoleman merged commit 53a355b into release/1.15.x Oct 27, 2023
@nathancoleman nathancoleman deleted the backport/nathancoleman-patch-1/eagerly-probable-sailfish branch October 27, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants