Backport of Fix casing in example yaml config into release/1.12.x#19403
Merged
nathancoleman merged 1 commit intorelease/1.12.xfrom Oct 27, 2023
Merged
Conversation
hc-github-team-consul-core
force-pushed
the
backport/nathancoleman-patch-1/badly-pro-pug
branch
2 times, most recently
from
fbd7513 to
bc5b187
Compare
|
|
github-team-consul-core-pr-approver
approved these changes
Oct 27, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
nathancoleman
force-pushed
the
backport/nathancoleman-patch-1/badly-pro-pug
branch
from
af6a211 to
c81c6d5
Compare
Member
|
Going ahead and merging since these are docs-only changes and license-check isn't running on this branch. Manual inspection shows that there are no copyright header changes included in this PR. |
nathancoleman
deleted the
backport/nathancoleman-patch-1/badly-pro-pug
branch
nathancoleman
restored the
backport/nathancoleman-patch-1/badly-pro-pug
branch
github-actions
bot
deleted the
backport/nathancoleman-patch-1/badly-pro-pug
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19369 to be assessed for backporting due to the inclusion of the label backport/1.12.
The below text is copied from the body of the original PR.
Description
This page in the docs has example code that is copy-pastable; however, it has a casing error which prevents the copied code from working for Kubernetes:
Testing & Reproduction steps
Copy-paste the modified examples and attempt to apply them to a Kubernetes cluster using
kubectl apply -f <filename>. Verify the command completes successfully instead of returning the above error.Links
Page containing broken example code
PR Checklist
Overview of commits