Skip to content

Add clarification for route match behavior #19363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kisunji merged 2 commits into from
Oct 25, 2023
Merged

Add clarification for route match behavior #19363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dba8d67
Add clarification for route match behavior
Oct 25, 2023
436cc19
Update website/content/docs/connect/config-entries/service-defaults.mdx
Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions agent/structs/config_entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ type InstanceLevelRateLimits struct {
RequestsMaxBurst int `alias:"requests_max_burst"`

// Routes is a list of rate limits applied to specific routes.
// For a given request, the first matching route will be applied, if any.
// Overrides any top-level configuration.
Routes []InstanceLevelRouteRateLimits
}
Expand Down
1 change: 1 addition & 0 deletions api/config_entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ type InstanceLevelRateLimits struct {
RequestsMaxBurst int `alias:"requests_max_burst"`

// Routes is a list of rate limits applied to specific routes.
// For a given request, the first matching route will be applied, if any
// Overrides any top-level configuration.
Routes []InstanceLevelRouteRateLimits
}
Expand Down
2 changes: 1 addition & 1 deletion website/content/docs/connect/config-entries/service-defaults.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ Specifies a list of rate limiting configurations to apply to specific routes to
- `PathPrefix`
- `PathRegex`

Refer to [Examples](#enable-request-rate-limit-on-a-prefixed-path) for example configurations.
Consul applies the rate limit configuration to the first matching route for each request. Refer to [Examples](#enable-request-rate-limit-on-a-prefixed-path) for example configurations.

#### Values

Expand Down