Backport of NET-6080 - xds controller golden file inputs into xds resources - destinations into release/1.17.x#19352
Merged
jmurret merged 8 commits intorelease/1.17.xfrom Oct 24, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/jm/NET-6080/repeatedly-innocent-mouse
branch
from
99eddcc to
11e6c2b
Compare
hc-github-team-consul-core
force-pushed
the
backport/jm/NET-6080/repeatedly-innocent-mouse
branch
2 times, most recently
from
e4548c7 to
11e6c2b
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 24, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
…tinations (#19244) * NET-5397 - wire up golden tests from sidecar-proxy controller for xds controller and xdsv2 * WIP * WIP * everything matching except leafCerts. need to mock those * single port destinations working except mixed destinations * golden test input to xds controller tests for destinations * proposed fix for failover group naming errors * clean up test to use helper. * clean up test to use helper. * fix test file * add docstring for test function. * add docstring for test function. * fix linting error * fixing test after route fix merged into main * first source test works * WIP * modify all source files * source tests pass * fixing tests after bug fix in main * got first destination working. * adding destinations * fix docstring for test * fixing tests after bug fix in main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19244 to be assessed for backporting due to the inclusion of the label backport/1.17.
🚨
The person who merged in the original PR is:
@jmurret
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
TestAllResourcesFromIR_XDSGoldenFileInputs tests the AllResourcesFromIR() by using the golden test output/expected files from the XDS controller tests as inputs to the XDSV2 resources generation.
In this PR destination proxy tests were added. Sources are included in a follow up PR: #19250
PR Checklist
Overview of commits