Closed
Conversation
WenInCode
added
theme/ui
added 20 commits
October 16, 2023 10:38
WenInCode
force-pushed
the
CC-5545/upgrade-hds-packages
branch
from
1187f61 to
645f1c1
Compare
4 tasks
Contributor
Author
|
closing in favour of #19226 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: This PR looks like it's extra long but most of the handlebars changes is just auto formatting on handlebars files where I had to update the
CopyButtoncomponent toConsulCopyButtondue to name collision. The majority of the actual changes are in thepackage.jsonand the modifier filesUpgrades HDS packages to latest releases ahead of work for adding the HDS Side Nav to the UI.
Upgrading
@hashicorp/design-system-componentscausedember-modifierto resolve to a4.xversion which was not compatible with a bunch of our class modifiers as well as one our packages that was outdated (ember-in-viewport). Due to this I explicitly updated consul-ui to use the latestember-modifierandember-in-viewportpackages.Because of the above I had to go through and update all the class based modifiers to use the new modifier structure.
Upgraded
ember-on-resize-modifierto fix issue where routing edge rects weren't getting set.A nice video where I find out routing of all things has an issue at the end:
(this ends with me finding an issue with routing edges which I fixed after, see next screenshot)
video1069237399.mp4
Testing & Reproduction steps
Links
CC-5545
PR Checklist