Backport of Golden File Tests for TermGW w/ Cluster Peering into release/1.16.x#19192
Merged
t-eckert merged 1 commit intorelease/1.16.xfrom Oct 30, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/termgw-httpfilters-golden/mentally-modern-ibex
branch
from
4c76f68 to
8ffc956
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 13, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Contributor
|
This branch has the correct diff, it just got funky because I updated the original PR branch from its target. |
t-eckert
approved these changes
Oct 26, 2023
t-eckert
deleted the
backport/termgw-httpfilters-golden/mentally-modern-ibex
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19096 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@t-eckert
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
This PR adds to the incomplete Golden file test for Terminating Gateways accepting peered trust bundles.
Testing & Reproduction steps
Running the unit tests for Consul.
Links
PR Checklist
Overview of commits