Conversation
rboyer
added
pr/no-changelog
…requests that are for the v1 catalog
rboyer
force-pushed
the
rboyer/reject-v1-catalog
branch
from
531cc0c to
14263bd
Compare
jmurret
reviewed
Oct 10, 2023
jmurret
approved these changes
Oct 10, 2023
Member
jmurret
left a comment
jmurret
left a comment
There was a problem hiding this comment.
👍 nice work! thank you for putting this together so efficiently!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the v2 catalog experiment is enabled the old v1 catalog apis will be forcibly disabled at both the API (json) layer and the RPC (msgpack) layer. This will also disable anti-entropy as it uses the v1 api.
This includes all of
/v1/catalog/*,/v1/health/*, most of/v1/agent/*,/v1/config/*, and most of/v1/internal/*.NET-5581