Skip to content

Make raft-wal default when resource-apis is active#19090

Merged
dhiaayachi merged 1 commit intomainfrom
raft-wal-default-v2-catalog
Oct 6, 2023
Merged

Make raft-wal default when resource-apis is active#19090
dhiaayachi merged 1 commit intomainfrom
raft-wal-default-v2-catalog

Conversation

@dhiaayachi
Copy link
Contributor

Description

This change the raft backend configuration behaviour as follow:

  • If no backend is specified, experiments=["resource-apis"] is set and no boltdb raft file is on disk the backend will be WAL
  • If WAL is set and no boltdb raft file is on disk WAL is used (this is haven't changed)
  • If Boltdb is set boltDB will be used (this is haven't changed)
  • If a db exist on disk using boltdb it will be used (this is haven't changed)

This is still missing the doc part that need to be added, I'm not sure if we add it right away or need to wait for the release.

Testing & Reproduction steps

Added config tests and manually tested that all the combinations above work as expected.

PR Checklist

  • updated test coverage
  • external facing docs updated

@dhiaayachi dhiaayachi requested a review from a team as a code owner October 5, 2023 21:02
@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label Oct 5, 2023
@dhiaayachi dhiaayachi added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport and removed pr/no-changelog PR does not need a corresponding .changelog entry labels Oct 5, 2023
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪵 🎉

@dhiaayachi
Copy link
Contributor Author

@ishustava @rboyer I will merge this as is, we need to document this when we add the documentation for experiments=["resource-apis"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport theme/config Relating to Consul Agent configuration, including reloading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants