Skip to content

Bump up compatibility test runner #19081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kisunji merged 4 commits into from
Oct 5, 2023
Merged

Bump up compatibility test runner #19081

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ccabe5
Bump up compatibility-integration-test runner
Oct 5, 2023
3962af6
No more verbose
Oct 5, 2023
c53bb7a
Add flags back
Oct 5, 2023
7265f25
back to 3
Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/test-integrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ concurrency:

jobs:
conditional-skip:
runs-on: ubuntu-latest
runs-on: ubuntu-latest
name: Get files changed and conditionally skip CI
outputs:
skip-ci: ${{ steps.read-files.outputs.skip-ci }}
steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
with:
fetch-depth: 0
fetch-depth: 0
- name: Get changed files
id: read-files
run: ./.github/scripts/filter_changed_files_go_test.sh
Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:
# multiplied by 8 based on these values:
# envoy-version: ["1.24.10", "1.25.9", "1.26.4", "1.27.0"]
# xds-target: ["server", "client"]
TOTAL_RUNNERS: 4
TOTAL_RUNNERS: 4
JQ_SLICER: '[ inputs ] | [_nwise(length / $runnercount | floor)]'
run: |
NUM_RUNNERS=$TOTAL_RUNNERS
Expand Down Expand Up @@ -375,7 +375,7 @@ jobs:
run: datadog-ci junit upload --service "$GITHUB_REPOSITORY" $TEST_RESULTS_DIR/results.xml

compatibility-integration-test:
runs-on: ${{ fromJSON(needs.setup.outputs.compute-large) }}
runs-on: ${{ fromJSON(needs.setup.outputs.compute-xl) }} # NOTE: do not change without tuning the -p and -parallel flags in go test.
needs:
- setup
- dev-build
Expand Down Expand Up @@ -431,11 +431,13 @@ jobs:
docker run --rm ${{ env.CONSUL_LATEST_IMAGE_NAME }}:local consul version
go run gotest.tools/gotestsum@v${{env.GOTESTSUM_VERSION}} \
--raw-command \
--format=standard-verbose \
--format=pkgname-and-test-fails \
--debug \
--rerun-fails=3 \
-- \
go test \
-p=6 \
-parallel=4 \
-tags "${{ env.GOTAGS }}" \
-timeout=30m \
-json \
Expand Down Expand Up @@ -487,7 +489,7 @@ jobs:


test-integrations-success:
needs:
needs:
- conditional-skip
- setup
- dev-build
Expand Down