Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
github-actions
bot
added
the
type/docs
kisunji
added
pr/no-changelog
kisunji
force-pushed
the
kisunji/vault-ca-upgrade
branch
from
afa5294 to
ebdb3f1
Compare
jkirschner-hashicorp
left a comment
jkirschner-hashicorp
left a comment
There was a problem hiding this comment.
Left some comments/questions. Overall looks good. Thanks for getting this up quickly!
|
|
||
| #### Service mesh compatibility ((#service-mesh-compatibility-1-15)) | ||
|
|
||
| Upgrade to **Consul version 1.15.2 or later**. |
There was a problem hiding this comment.
Do these all belong within a "service mesh compatibility" section (like exists for 1.15 and 1.14)?
And would it affect our upgrade guidance here? Like ... upgrade to Consul 1.15.2 or later, but avoid 1.15.6 if [using Vault Enterprise as a CA](link to anchor tag).
There was a problem hiding this comment.
I moved around the sections so they fall under "service mesh compatibility" except for 1.16 which didn't have the section.
|
|
||
| ## Consul 1.16.x | ||
|
|
||
| #### Vault Enterprise as CA |
There was a problem hiding this comment.
I think we should add to KNOWN ISSUES in the changelog
The changelog content can link to the applicable upgrade guidance section in our docs (here) once published.
The changelog PR can be separate (since it won't be backported in any way).
jkirschner-hashicorp
left a comment
jkirschner-hashicorp
left a comment
There was a problem hiding this comment.
LGTM.
Note that auto-backporting to 1.15 and 1.14 probably won't work as intended here... They 1.16 part of the diff will be misplaced on the 1.15 and 1.14 versions of the docs site.
|
|
||
| This bug is fixed in Consul versions 1.15.2 and newer. | ||
|
|
||
| #### Vault Enterprise as CA ((#vault-enterprise-as-ca-1-15)) |
There was a problem hiding this comment.
Nice catch on the anchor alias ;)
kisunji
removed
backport/1.14
backport/1.15
2 participants
Backports
1.15.x
1.14.x