Skip to content

docs: Multi-port and catalog changes#19050

Merged
boruszak merged 18 commits intomainfrom
docs/multiport-rc
Oct 10, 2023
Merged

docs: Multi-port and catalog changes#19050
boruszak merged 18 commits intomainfrom
docs/multiport-rc

Conversation

@boruszak
Copy link
Contributor

@boruszak boruszak commented Oct 3, 2023

Description

As part of the Consul v1.17 release, multi-port services and the v2 catalog API are part of a release candidate/feature preview.

This PR creates two new pages to support the initial catalog changes. This content will be expanded and updated over time, and has additional updates scheduled to release at the end of the month.

As a result, this content documents multi-port and catalog as they exist in the current release. Please do not suggest edits that describe the future functionality of these features.

The following pages were updates (links open deployment previews):

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 9:30pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
consul-ui-staging ⬜️ Ignored (Inspect) Oct 3, 2023 9:30pm

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 3, 2023
@digital-content-events
Copy link

digital-content-events bot commented Oct 3, 2023

📄 Content Checks

Updated: Thu, 05 Oct 2023 21:46:43 GMT

Found 1 error(s)

content/docs/k8s/multiport/index.mdx

Position Description Rule
64:135-64:185 Unexpected folder-relative link found: consul/docs/connect/dataplane. Ensure this link is an absolute Developer path. ensure-valid-link-format

@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry pr/do-not-merge PR cannot be merged in its current form. pr/no-metrics-test pr/no-backport labels Oct 3, 2023
@boruszak boruszak marked this pull request as ready for review October 3, 2023 21:23
@boruszak boruszak requested a review from a team as a code owner October 3, 2023 21:23
@david-yu david-yu mentioned this pull request Oct 5, 2023
2 tasks
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more suggestions. Feel free to ignore anything you don't agree with.

Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are looking great, just a couple comments so far

Co-authored-by: Dan Stough <dan.stough@hashicorp.com>
@boruszak boruszak removed the pr/do-not-merge PR cannot be merged in its current form. label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants