Skip to content

Reduce number of ports that consul test agents take#19047

Merged
kisunji merged 1 commit intomainfrom
kisunji/conserve-ports
Oct 3, 2023
Merged

Reduce number of ports that consul test agents take#19047
kisunji merged 1 commit intomainfrom
kisunji/conserve-ports

Conversation

@kisunji
Copy link
Contributor

@kisunji kisunji commented Oct 3, 2023

Description

After I increased test parallelism in #18999, I noticed random tests would panic due to not enough ports being free:

2023-10-03T16:41:26.3801137Z === �[31mFAIL�[0m: command/monitor TestMonitorCommand_exitsOnSignalBeforeLinesArrive (0.00s)
2023-10-03T16:41:26.3801752Z     testagent.go:417: failed to take 8 ports: %!w(*errors.errorString=&{freeport: block size too small})
2023-10-03T16:41:26.3802154Z panic: freeport: cannot allocate port block [recovered]
2023-10-03T16:41:26.3802542Z 	panic: freeport: cannot allocate port block [recovered]
2023-10-03T16:41:26.3802949Z 	panic: freeport: cannot allocate port block

This PR attempts to reduce reserved ports by 1, hoping to reduce the frequency of these panics.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
consul ⬜️ Ignored (Inspect) Oct 3, 2023 5:00pm
consul-ui-staging ⬜️ Ignored (Inspect) Oct 3, 2023 5:00pm

@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 3, 2023
@kisunji kisunji requested a review from dhiaayachi October 3, 2023 17:46
Copy link
Contributor

@johnlanda johnlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kisunji kisunji enabled auto-merge (squash) October 3, 2023 18:56
@kisunji kisunji merged commit 41e6f6c into main Oct 3, 2023
@kisunji kisunji deleted the kisunji/conserve-ports branch October 3, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants