Include RequestTimeout in marshal/unmarshal of ServiceResolverConfigE…#19031
Merged
Include RequestTimeout in marshal/unmarshal of ServiceResolverConfigE…#19031
Conversation
roncodingenthusiast
approved these changes
Sep 29, 2023
This was referenced Sep 29, 2023
cthain
added a commit
that referenced
this pull request
Oct 3, 2023
cthain
added a commit
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where we’re missing the custom JSON marshal and unmarshal for the
ServiceResolverConfigEntry.RequestTimeoutfield. This has the effect that the config entry can be written successfully to Consul but it cannot be read back through the API.Testing & Reproduction steps
Before the changes proposed in this PR:
After these changes:
PR Checklist
external facing docs updated