Fix Traffic Permissions Default Deny#19028
Merged
erichaberkorn merged 1 commit intomainfrom Oct 4, 2023
Merged
Conversation
erichaberkorn
added
pr/no-changelog
erichaberkorn
force-pushed
the
fix-default-deny-traffic-permissions
branch
4 times, most recently
from
59fed97 to
e414058
Compare
ishustava
reviewed
Oct 3, 2023
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
Looks great! Just one question about skipping allow perms in default allow mode
agent/xdsv2/rbac_resources.go
Outdated
Contributor
There was a problem hiding this comment.
🤔 what if I want to do the following in default-allow mode:
- create an allow-nothing traffic permission in a partition
- create an allow permission to a specific destination
Contributor
There was a problem hiding this comment.
I think I misunderstood that this means default allow only if there are no traffic perms thinking that this is a global default. Maybe a comment here would be helpful
Contributor
There was a problem hiding this comment.
It'd be nice to add docs here because this value does not necessarily behave like the global default
ishustava
approved these changes
Oct 3, 2023
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
Looks great! Thanks so much for fixing it!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
erichaberkorn
force-pushed
the
fix-default-deny-traffic-permissions
branch
3 times, most recently
from
2bcba2b to
a83766a
Compare
…rn on default deny. Previously, this was only working at the port level.
erichaberkorn
force-pushed
the
fix-default-deny-traffic-permissions
branch
from
a83766a to
9564a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever a traffic permission exists for a given workload identity, turn on default deny. Previously, this only worked at the port level.
PR Checklist