Skip to content

Remove explicit -p from CI tests #18999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kisunji merged 3 commits into from
Oct 3, 2023
Merged

Remove explicit -p from CI tests #18999

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97dc454
Dump response body on fail
Sep 25, 2023
4dcd177
Remove p flag
Sep 25, 2023
c25f035
Revert test
Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/reusable-unit-split.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ jobs:
--rerun-fails-report=/tmp/gotestsum-rerun-fails \
--packages="$PACKAGE_NAMES" \
--junitfile ${{env.TEST_RESULTS}}/gotestsum-report.xml -- \
-tags="${{env.GOTAGS}}" -p 2 \
${GO_TEST_FLAGS-} \
Copy link
Contributor Author

@kisunji kisunji Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what this line was doing. In L118 we already process go-test-flags so I assume this is a remnant of our CircleCI workflows

-tags="${{env.GOTAGS}}" \
-cover -coverprofile=coverage.txt

# NOTE: ENT specific step as we store secrets in Vault.
Expand Down