Backport of when skip-ci is true do not trigger integration and go tests into release/1.15.x#18955
Merged
NiniOak merged 1 commit intorelease/1.15.xfrom Sep 21, 2023
Conversation
d59f575 to
7c73e45
Compare
github-team-consul-core-pr-approver
approved these changes
Sep 21, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18948 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
PROBLEM
Actions was not correctly reading the result of script to not run CI, it continuously ran CI when changes were only to docs file. See example here
SOLUTION
Push the result of script to GITHUB_OUTPUT which can be read easily by Github Actions to execute workflows conditionally.
Testing & Reproduction steps
CI runs all workflows where non doc files are included in changeset
CI skips test workflows when only doc files are in changeset
Links
PR Checklist
Overview of commits