Skip to content

Fix for loop in filter_changed_files_go_test script #18931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NiniOak merged 2 commits into from
Sep 20, 2023
Merged

Fix for loop in filter_changed_files_go_test script #18931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5531f2
iterate through array
NiniOak Sep 20, 2023
1caef16
remove comment
NiniOak Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/filter_changed_files_go_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ files_to_check=$(git diff --name-only "$(git merge-base origin/$SKIP_CHECK_BRANC
skipped_directories=("docs/" "ui/" "website/" "grafana/")

# Loop through the changed files and find directories/files outside the skipped ones
for file_to_check in $files_to_check; do
for file_to_check in "${files_to_check[@]}"; do
file_is_skipped=false
for dir in "${skipped_directories[@]}"; do
if [[ "$file_to_check" == "$dir"* ]] || [[ "$file_to_check" == *.md && "$dir" == *"/" ]]; then
Expand Down