Skip to content

Add V2 TCP traffic permissions #18771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erichaberkorn merged 3 commits into from
Sep 13, 2023
Merged

Add V2 TCP traffic permissions #18771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0df82f5
Add support for TCP traffic permissions
erichaberkorn Sep 7, 2023
29a4aa2
fixup! Add support for TCP traffic permissions
erichaberkorn Sep 11, 2023
b16a591
fixup! Add support for TCP traffic permissions
erichaberkorn Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions agent/xds/proxystateconverter/listeners.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ func (s *Converter) makeInboundListener(cfgSnap *proxycfg.ConfigSnapshot, name s
if l7Dest == nil {
return nil, fmt.Errorf("l7 destination on inbound listener should not be empty")
}
l7Dest.AddEmptyIntention = true

// TODO(proxystate): L7 Intentions and JWT Auth will be added in the future.
//jwtFilter, jwtFilterErr := makeJWTAuthFilter(cfgSnap.JWTProviders, cfgSnap.ConnectProxy.Intentions)
Expand Down Expand Up @@ -1053,8 +1052,7 @@ func (s *Converter) makeInboundListener(cfgSnap *proxycfg.ConfigSnapshot, name s
l4Dest.MaxInboundConnections = uint64(cfg.MaxInboundConnections)
}

// TODO(proxystate): Intentions will be added to l4 destination in the future. This is currently done in finalizePublicListenerFromConfig.
l4Dest.AddEmptyIntention = true
l4Dest.TrafficPermissions = &pbproxystate.L4TrafficPermissions{}
}
l.Routers = append(l.Routers, localAppRouter)

Expand Down Expand Up @@ -1575,7 +1573,7 @@ func (g *Converter) makeL7Destination(opts destinationOpts) (*pbproxystate.L7Des
// access and that every filter chain uses our TLS certs.
if len(opts.httpAuthzFilters) > 0 {
// TODO(proxystate) support intentions in the future
dest.Intentions = make([]*pbproxystate.L7Intention, 0)
dest.TrafficPermissions = &pbproxystate.L7TrafficPermissions{}
//cfg.HttpFilters = append(opts.httpAuthzFilters, cfg.HttpFilters...)
}

Expand Down
Loading