Backport of Removed nodename and status from consul snapshot save -append-filename command and using leader version in version into release/1.15.x#18685
Merged
asheshvidyut merged 3 commits intorelease/1.15.xfrom Sep 6, 2023
Conversation
added 2 commits
September 5, 2023 16:33
864f1fb to
d3d2482
Compare
4e85c88 to
35dc208
Compare
github-team-consul-core-pr-approver
approved these changes
Sep 6, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Collaborator
Author
|
🤔 This PR has changes in the |
…e command and using leader version in version (#18680) * init * fix tests * fix tests lint * fix api call inside dc * updated doc * address comments
asheshvidyut
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18680 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@absolutelightning
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Using leader version in version. Also removes nodename and status in consul snapshot save -append-filename command
Testing & Reproduction steps
make dev./bin/consul agent -dev -config-file=../server.json./bin/consul snapshot save -append-filename version,dc snap.bkpLinks
PR Checklist
Overview of commits