UI: Add enterprise suffix to UI version number#18542
Closed
Conversation
781773d to
ef4f441
Compare
This fix checks the Consul Binary type, and for non-Community (i.e. Enterprise) binary versions, a "+ent" suffix is added to the version number of Consul that is displayed in the UI so that operators viewing the UI can see their enterprise license reflected in the sidebar.
ef4f441 to
093aea6
Compare
Contributor
|
@evrowe forgot to mention this to you before. Can we move this to a branch that has a Do we want to backport this at all? |
Contributor
Author
|
@WenInCode Oh right, totally forgot about that convention! Yes I'll make that change. I'm fine to backport to 1.16 and 1.15, was holding off on adding those labels until I converted this out of draft phase but I'll add them after I update the branch name |
Contributor
Author
|
Closing in favor of #18559 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix checks the Consul Binary type, and for non-Community (i.e. Enterprise) binary versions, a "+ent" suffix is added to the version number of Consul that is displayed in the UI so that operators viewing the UI can see their enterprise license reflected in the sidebar.
Testing & Reproduction steps
1.15.0)ui/packages/consul-ui/config/environment.jsand change line78to read:make ui-dockerto build the ui imagemake dev-dockersetups/peeringdirectorydocker-compose upNow, check out this branch and repeat the above steps 1-9.
Observe the index page and note the version number in the lower right corner of the UI now shows the version number with the "+ent" suffix appended, i.e.
Consul v1.17.0+entLinks
PR Checklist