Skip to content

Backport of [docs] Fix ServiceDefaults example in distributed tracing into release/1.14.x#18391

Merged
blake merged 1 commit intorelease/1.14.xfrom
backport/patch-1/greatly-artistic-mongoose
Aug 4, 2023
Merged

Backport of [docs] Fix ServiceDefaults example in distributed tracing into release/1.14.x#18391
blake merged 1 commit intorelease/1.14.xfrom
backport/patch-1/greatly-artistic-mongoose

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Aug 4, 2023

Backport

This PR is auto-generated from #17212 to be assessed for backporting due to the inclusion of the label backport/1.14.

The below text is copied from the body of the original PR.

Description

Fix ServiceDefaults example in distributed tracing

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/patch-1/greatly-artistic-mongoose branch from 263488e to 5bd2275 Compare August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/patch-1/greatly-artistic-mongoose branch from 5bd2275 to f376da5 Compare August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core requested review from randyhdev and sarahethompson and removed request for a team August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/patch-1/greatly-artistic-mongoose branch from 2344e0f to fbcca36 Compare August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) August 4, 2023 23:07
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/patch-1/greatly-artistic-mongoose branch from 03ba7c7 to 6e5859e Compare August 4, 2023 23:07
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality theme/acls ACL and token generation theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/ui Anything related to the UI theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication theme/telemetry Anything related to telemetry or observability type/ci Relating to continuous integration (CI) tooling for testing or releases pr/dependencies PR specifically updates dependencies of project theme/envoy/xds Related to Envoy support theme/contributing Additions and enhancements to community contributing materials theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics labels Aug 4, 2023
@github-actions github-actions bot added theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/agent-cache Agent Cache theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Aug 4, 2023
@hc-github-team-consul-core
Copy link
Collaborator Author

hc-github-team-consul-core commented Aug 4, 2023

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 4, 2023 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 4, 2023 23:17 Inactive
@blake blake disabled auto-merge August 4, 2023 23:20
@blake blake removed theme/api Relating to the HTTP API interface theme/health-checks Health Check functionality theme/acls ACL and token generation theme/cli Flags and documentation for the CLI interface theme/config Relating to Consul Agent configuration, including reloading theme/ui Anything related to the UI theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication theme/telemetry Anything related to telemetry or observability type/ci Relating to continuous integration (CI) tooling for testing or releases pr/dependencies PR specifically updates dependencies of project theme/envoy/xds Related to Envoy support theme/contributing Additions and enhancements to community contributing materials theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/agent-cache Agent Cache theme/consul-terraform-sync Relating to Consul Terraform Sync and Network Infrastructure Automation labels Aug 4, 2023
@blake blake force-pushed the backport/patch-1/greatly-artistic-mongoose branch from 6e5859e to 2efab9d Compare August 4, 2023 23:27
@blake blake enabled auto-merge (squash) August 4, 2023 23:28
@blake blake merged commit db8a5bc into release/1.14.x Aug 4, 2023
@blake blake deleted the backport/patch-1/greatly-artistic-mongoose branch August 4, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@sarahethompson sarahethompson Awaiting requested review from sarahethompson

@randyhdev randyhdev Awaiting requested review from randyhdev

@blake blake Awaiting requested review from blake

Assignees

@blake blake

Labels

type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hc-github-team-consul-core @github-team-consul-core-pr-approver @blake @ilpianista