Skip to content

Fix #17730 - Dev mode has new line #18367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asheshvidyut merged 2 commits into from
Aug 5, 2023
Merged

Fix #17730 - Dev mode has new line #18367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2489a2
adding new line only in case of pretty in url not in dev mode
Aug 3, 2023
daf4cf3
change log added
Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/18367.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
dev-mode: Fix dev mode has new line in responses. Now new line is added only when url has pretty query parameter.
```
4 changes: 3 additions & 1 deletion agent/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,9 @@ func (s *HTTPHandlers) marshalJSON(req *http.Request, obj interface{}) ([]byte,
if err != nil {
return nil, err
}
buf = append(buf, "\n"...)
if ok {
buf = append(buf, "\n"...)
}
return buf, nil
}

Expand Down