Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

hashicorp / consul Public

Notifications You must be signed in to change notification settings
Fork 4.6k
Star 29.8k

Code
Issues 1.3k
Pull requests 88
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration#18168

Merged

Achooo merged 42 commits intomainhashicorp/consul:mainfrom

cc-4960/hcp-telemetry-periodic-refreshhashicorp/consul:cc-4960/hcp-telemetry-periodic-refreshCopy head branch name to clipboard

Aug 1, 2023

Conversation Commits42 (42)Checks Files changed

Merged

[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration#18168
Achooo merged 42 commits intomainfrom
cc-4960/hcp-telemetry-periodic-refresh

Commits

Commits on Jul 31, 2023

OTElExporter now uses an EndpointProvider to discover the endpoint
Achooo
committed
OTELSink uses a ConfigProvider to obtain filters and labels configuration
Achooo
committed
improve tests for otel_sink
Achooo
committed
Regex logic is moved into client for a method on the TelemetryConfig object
Achooo
committed
Create a telemetry_config_provider and update deps to use it
Achooo
committed
Fix conversion
Achooo
committed
fix import newline
Achooo
committed
Add logger to hcp client and move telemetry_config out of the client.go file
Achooo
committed
Add a telemetry_config.go to refactor client.go
Achooo
committed
Update deps
Achooo
committed
update hcp deps test
Achooo
committed
Modify telemetry_config_providers
Achooo
committed
Check for nil filters
Achooo
committed
PR review updates
Achooo
committed
Fix comments and move around pieces
Achooo
committed
Fix comments
Achooo
committed
Remove context from client struct
Achooo
committed
Moved ctx out of sink struct and fixed filters, added a test
Achooo
committed
Remove named imports, use errors.New if not fformatting
Achooo
committed
Remove HCP dependencies in telemetry package
Achooo
committed
Add success metric and move lock only to grab the t.cfgHahs
Achooo
committed
Update hash
Achooo
committed
fix nits
Achooo
committed
Create an equals method and add tests
Achooo
committed
Improve telemetry_config_provider.go tests
Achooo
committed
Add race test
Achooo
committed
Add missing godoc
Achooo
committed
Remove mock for MetricsClient
Achooo
committed
Avoid goroutine test panics
Achooo
committed
trying to kick CI lint issues by upgrading mod
Achooo
committed
imprve test code and add hasher for testing
Achooo
committed
Use structure logging for filters, fix error constants, and default to allow all regex
Achooo
committed
removed hashin and modify logic to simplify
Achooo
committed
Improve race test and fix PR feedback by removing hash equals and avoid testing the timer.Ticker logic, and instead unit test
Achooo
committed
Ran make go-mod-tidy
Achooo
committed
Use errtypes in the test
Achooo
committed
Add changelog
Achooo
committed
add safety check for exporter endpoint
Achooo
committed

Commits on Aug 1, 2023

remove require.Contains by using error types, fix structure logging, and fix success metric typo in exporter
Achooo
committed
Fixed race test to have changing config values
Achooo
committed
Send success metric before modifying config
Achooo
committed
Avoid the defer and move the success metric under
Achooo
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.