docs - helm consul k8s 1.1.x helm chart reference#18057
Merged
david-yu merged 3 commits intorelease/1.15.xfrom Jul 10, 2023
Merged
docs - helm consul k8s 1.1.x helm chart reference#18057david-yu merged 3 commits intorelease/1.15.xfrom
david-yu merged 3 commits intorelease/1.15.xfrom
Conversation
github-actions
bot
added
the
type/docs
david-yu
added
pr/no-changelog
DanStough
approved these changes
Jul 10, 2023
Contributor
DanStough
left a comment
DanStough
left a comment
There was a problem hiding this comment.
Minor edits you can take or leave.
|
|
||
| - `secretName` ((#v-global-secretsbackend-vault-connectinject-cacert-secretname)) (`string: null`) - The Vault secret path that contains the CA certificate for | ||
| connect inject webhooks. | ||
| Connect Inject webhooks. |
Contributor
There was a problem hiding this comment.
This is one word in the rest of the edits.
Suggested change
| Connect Inject webhooks. | |
| ConnectInject webhooks. |
Contributor
Author
There was a problem hiding this comment.
Hmm will think about these connect inject differences in a separate PR in consul-k8s later.
| - `connectInject` ((#v-connectinject)) - Configures the automatic Connect sidecar injector. | ||
|
|
||
| - `enabled` ((#v-connectinject-enabled)) (`boolean: true`) - True if you want to enable service mesh sidecar injection. Set to "-" to inherit from | ||
| - `enabled` ((#v-connectinject-enabled)) (`boolean: true`) - True if you want to enable connect injection. Set to "-" to inherit from |
Contributor
There was a problem hiding this comment.
one word ConnectInject or Connect injection because it is a proper noun.
Co-authored-by: Dan Stough <dan.stough@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes from 1.1.x. Reviewing to see if these are correct.
Testing & Reproduction steps
Links
PR Checklist