Backport of Document that DNS lookups can target cluster peers into release/1.15.x#18025
Merged
david-yu merged 1 commit intorelease/1.15.xfrom Jul 5, 2023
Conversation
github-team-consul-core-pr-approver
approved these changes
Jul 5, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17990 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@david-yu
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
Static DNS lookups, in addition to explicitly targeting a datacenter, can target a cluster peer. This was added in 95dc0c7 (1.15.0) but didn't make the documentation.
The driving function for the behavior change is
parseLocalityhere:consul/agent/dns_oss.go
Lines 25 to 44 in 0b1299c
The biggest documentation change I've proposed is to adjust the standard lookup syntax to tie
.<datacenter>to.dcas required-together, and to append in the similar.<cluster-peer>.peeroptional argument, both to A record and SRV record lookups. This more matches my understanding of how to show that they have to be added as pairs for the directed lookups to work.Testing & Reproduction steps
Documentation-only
Links
parseLocalityfunction:consul/agent/dns_oss.go
Line 25 in 0b1299c
Exported Services docs: https://developer.hashicorp.com/consul/docs/connect/config-entries/exported-services
Cluster Peering overview: https://developer.hashicorp.com/consul/docs/connect/cluster-peering
PR Checklist
Overview of commits