Backport of watch: support -filter for consul watch: checks, services, nodes, service into release/1.15.x#17986
Merged
david-yu merged 6 commits intorelease/1.15.xfrom Jun 30, 2023
Conversation
a5cf3dd to
a29b6af
Compare
12d5ec6 to
fb5ac3b
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 30, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
huikang
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17780 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@huikang
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
-filterforwatch -type=checks, services,nodes, andservice(see use case in Add option to further filter Consul Watch -type=checks -state=X by Tag #17642)Before:
After
We can also support filtering by service name and status for check types as suggested by the user (see test case
TestChecksWatch_Filter_by_ServiceNameStatusin the PR)Testing & Reproduction steps
Links
#17642
PR Checklist
Overview of commits