Backport of Add emit_tags_as_labels to envoy bootstrap config when using Consul Telemetry Collector into release/1.16.x#17901
Merged
hc-github-team-consul-core merged 3 commits intorelease/1.16.xfrom Jun 27, 2023
Conversation
d6b72ce to
1e6dc85
Compare
fd1946d to
6bed88a
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 27, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17888 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
This flips an Envoy flag on so metrics sent to the Consul Telemetry Collector get all the tags that we create via regexes:
consul/command/connect/envoy/bootstrap_config.go
Line 352 in 94584cf
Testing & Reproduction steps
I made this change directly to
consul-dataplane, deployed it to a personal Docker Hub repo, and ranconsul-k8s installwith it:Checked Prometheus and we're getting all the labels:
Links
Envoy docs: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/metrics_service.proto
PR Checklist
Overview of commits