Backport of docs: add note about path prefix matching behavior for HTTPRoute config into release/1.16.x#17861
Merged
hc-github-team-consul-core merged 2 commits intorelease/1.16.xfrom Jun 23, 2023
Conversation
4460094 to
23723ce
Compare
8be7fd1 to
c1913a9
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 23, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
nathancoleman
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17860 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
The Gateway API spec says the following about path prefix route matches (source):
Consul API Gateway does simple string prefix comparison today, which is the same thing that the rest of Consul does. The result is that, contrary to the specification above, we do match
/abcd. This is because Consul usesRouteMatch_Prefixacross the board for prefix matching when generating xDS instead ofRouteMatch_PathSeparatedPrefix.This PR just calls out that difference in the docs so we don't surprise anyone as much as we can help it.
Testing & Reproduction steps
N/A
Links
Vercel preview of added note
PR Checklist
Overview of commits