Backport of Update service-defaults.mdx into release/1.16.x#17672
Merged
im2nguyen merged 1 commit intorelease/1.16.xfrom Jun 12, 2023
Merged
Backport of Update service-defaults.mdx into release/1.16.x#17672im2nguyen merged 1 commit intorelease/1.16.xfrom
im2nguyen merged 1 commit intorelease/1.16.xfrom
Conversation
hc-github-team-consul-core
force-pushed
the
backport/patch-5/apparently-healthy-dassie
branch
from
cdb7c5a to
751e11b
Compare
hc-github-team-consul-core
force-pushed
the
backport/patch-5/apparently-healthy-dassie
branch
from
6b77635 to
78b9576
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 12, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
bot
added
the
type/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17656 to be assessed for backporting due to the inclusion of the label backport/1.16.
🚨
The person who merged in the original PR is:
@im2nguyen
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
when using service-defaults for external services, if the client is dialing an HTTPS (encrypted) traffic, protocol should be set to TCP and port 443.
Testing & Reproduction steps
PR Checklist
Overview of commits