Backport of api-gateway: stop adding all header filters to virtual host when generating xDS into release/1.16.x#17658
Merged
hc-github-team-consul-core merged 3 commits intorelease/1.16.xfrom Jun 12, 2023
Conversation
5238dd0 to
31fd8c2
Compare
8204d08 to
2bb4c4b
Compare
github-team-consul-core-pr-approver
approved these changes
Jun 12, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
nathancoleman
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17644 to be assessed for backporting due to the inclusion of the label backport/1.16.
The below text is copied from the body of the original PR.
Description
Header filters on http-route rules are being added to the virtual host and the route when generating xDS.
This is demonstrated by stepping through the commits in this PR:
Testing & Reproduction steps
Links
PR Checklist
Overview of commits