Backport of docs: clarify the behavior of prepending hostname to metrics into release/1.14.x#17579
Closed
hc-github-team-consul-core wants to merge 2 commits intorelease/1.14.xfrom
Conversation
edc9478 to
17ef0ef
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
github-team-consul-core-pr-approver
approved these changes
Jun 5, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
…oc/probably-promoted-lynx
Collaborator
|
not applicable to 1.14 since the file doesn't exit, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17521 to be assessed for backporting due to the inclusion of the label backport/1.14.
🚨
The person who merged in the original PR is:
@huikang
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
The prepended name to the gauge metrics causes some confusion on how to query the metrics. According to the
go-metrics' godoc,EnableHostnameis only applicable to gauge metrics:Consul initializes the
metrics.configwith the agent configuration value “telemetry.disable_hostname”.consul/lib/telemetry.go
Lines 327 to 329 in 720dda7
Therefore, if
disable_hostnameisfalse, hostname will be added to gauge metric names (the default behavior); otherwise, no hostname will be prepended to the metrics name of gauge type. That said,disable_hostnamehas no impact on other types of metrics.This PR clarifies this behavior in consul's doc.
Links
fix #17320
PR Checklist
Overview of commits