Backport of HCP Telemetry Feature into release/1.15.x#17501
Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
Closed
Backport of HCP Telemetry Feature into release/1.15.x#17501hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
hc-github-team-consul-core wants to merge 1 commit intorelease/1.15.xfrom
Conversation
cc7c2e9 to
d60e96f
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
github-team-consul-core-pr-approver
approved these changes
May 29, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17460 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@Achooo
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
This is the final PR for the merge of the HCP Telemetry feature branch (
feature/hcp-telemetry) intomainA feature branch was used, where the code was thoroughly reviewed in multiple PRs, as seen by the commit history, in order:
Feature background
RFC: [CSL-267] Export Server Metrics to HCP
The new HCP Observability feature requires sending Consul Server metrics to HCP's new Telemetry Gateway.
The idea is to create a new OpenTelemetry Go Metrics sink that will be initialized automatically within the fanout sink when a Consul server is registered with the HCP management plane.
Testing & Reproduction steps
Links
PR Checklist
Overview of commits