Backport of perf: Remove expensive reflection from raft/mesh hot path into release/1.14.x#17492
Merged
hc-github-team-consul-core merged 2 commits intorelease/1.14.xfrom May 26, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/lstoll-deepcopy-upstreamdownstream/grossly-sincere-phoenix
branch
from
a793c5c to
0c44166
Compare
hc-github-team-consul-core
force-pushed
the
backport/lstoll-deepcopy-upstreamdownstream/grossly-sincere-phoenix
branch
from
a246621 to
fca4738
Compare
github-team-consul-core-pr-approver
approved these changes
May 26, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
hc-github-team-consul-core
deleted the
backport/lstoll-deepcopy-upstreamdownstream/grossly-sincere-phoenix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16552 to be assessed for backporting due to the inclusion of the label backport/1.14.
The below text is copied from the body of the original PR.
Description
Replaces a reflection-based copy of a struct in the mesh topology with a deep-copy generated implementation.
This is in the hot-path of raft FSM updates, and the reflection overhead was a substantial part of mesh registration times (~90%). This could manifest as raft thread saturation, and resulting instability.
This is a similar problem/fix as #14934, it might be worth seeing if there are any other uses of the reflection copy library and replacing it with (generated) copies.
Fixes #16551
Testing & Reproduction steps
Details in issue #16551 . The before/after from the test case in that issue:
After the change was rolled out, we no longer saw any registration delays and the general raft/FSM thread saturation dropped off substantially
PR Checklist
Overview of commits