[Release/1.14.x] net 3914 gha consul container test no splitting#17474
Merged
huikang merged 1 commit intorelease/1.14.xfrom May 25, 2023
Merged
Conversation
Signed-off-by: cskh <hui.kang@hashicorp.com>
github-actions
bot
added
theme/contributing
huikang
added
pr/no-backport
pr/no-changelog
huikang
commented
May 25, 2023
| working-directory: ${{ matrix.directory }} | ||
| version: v1.51.1 | ||
| args: --build-tags="${{ env.GOTAGS }}" -v | ||
| skip-cache: true |
Collaborator
Author
There was a problem hiding this comment.
copied from ent version.
huikang
deleted the
release/1.14.x-NET-3914-gha-consul-container-test-no-splitting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport #17394
Backport removing test splitting to 1.14.x. Note that in 1.14.x, we don't have actual upgrade test yet (upgrade test for service mesh was added since 1.15.x). The upgrade tests in 1.14.x tests the combination between consul:local and the latest patched version of 1.14.x.
This PR also fixes some issue of passing image name and version arguments in creating consul containers. The problem was not exposed because some of the tests were not triggered.
Links
PR Checklist