Skip to content

xds: Remove APIGateway ToIngress function#17453

Merged
sarahalsmiller merged 24 commits intomainfrom
NET-4150-remove-to-ingress
May 25, 2023
Merged

xds: Remove APIGateway ToIngress function#17453
sarahalsmiller merged 24 commits intomainfrom
NET-4150-remove-to-ingress

Conversation

@sarahalsmiller
Copy link
Member

Description

As the final push for converting the APIGateway to XDS Primitives, this PR cleans up the ToIngress function, as well as any code that was specifically there to enable it, as ToIngress is no longer being called.

Testing & Reproduction steps

CI tests pass

Links

Depends on NET-3672-routesForAPIGateway successfully merging.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@sarahalsmiller sarahalsmiller requested review from a team and nathancoleman May 24, 2023 19:24
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label May 24, 2023
@sarahalsmiller sarahalsmiller added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport and removed theme/envoy/xds Related to Envoy support labels May 24, 2023
Base automatically changed from NET-3672-routesForAPIGateway to main May 25, 2023 14:54
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) May 25, 2023 15:01
@sarahalsmiller sarahalsmiller merged commit b147323 into main May 25, 2023
@sarahalsmiller sarahalsmiller deleted the NET-4150-remove-to-ingress branch May 25, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants