CI: do not upload test metrics to datadog on forks#17448
Merged
Conversation
jmurret
added
pr/no-changelog
github-actions
bot
added
theme/contributing
dhiaayachi
approved these changes
May 24, 2023
Contributor
dhiaayachi
left a comment
dhiaayachi
left a comment
There was a problem hiding this comment.
🚀 🚀 🚀
Thank you @jmurret!!
loshz
approved these changes
May 24, 2023
This was referenced May 24, 2023
jmurret
added a commit
that referenced
this pull request
May 24, 2023
* bypass uploading testmetrics to datadog on forks / when api is not available * add exclusions to upgrade tests
jmurret
added a commit
that referenced
this pull request
May 24, 2023
* bypass uploading testmetrics to datadog on forks / when api is not available * add exclusions to upgrade tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tested that these changes work on PR from fork: #17445
Testing & Reproduction steps
expected results:
go-testsandtest-integrationspass.actual results: both workflows fail when trying to upload test coverage data to DataDog because the DD API key is not present (since the fork does not contain it).
PR Checklist