JWT Authentication with service intentions: xds package update#17414
JWT Authentication with service intentions: xds package update#17414roncodingenthusiast merged 6 commits intomainfrom
Conversation
kisunji
left a comment
There was a problem hiding this comment.
Great work! Working in xds is not easy but this looks good.
I had a few blocking comments and general questions
6e2b7b6 to
50ba1fd
Compare
agent/xds/jwt_authn.go
Outdated
There was a problem hiding this comment.
This should be moved before the for-loop over intentions for the early return
There was a problem hiding this comment.
We need to check for len(providers) == 0 following the loop as well, right? For the common case where there are intentions but no intentions contain any JWT requirements.
There was a problem hiding this comment.
Ah yes, thanks for the correction. Maybe this can stay here and simplify to if len(providers) == 0
There was a problem hiding this comment.
ah true, i will update it! thank you both
kisunji
left a comment
There was a problem hiding this comment.
One more minor comment but LGTM! 👍
6421487 to
1146f2a
Compare
Description
This PR enables envoy config updates when we write jwt providers/intentions. Porting these changes from the enterprise PR
Testing & Reproduction steps
./bin/consul agent -devconsul services register your-service.hcl your-proxy.hclconsul connect envoy -sidecar-for your-service -grpc-addr 127.0.0.1:8502consul config write provider.hcl intention.hclcurl "localhost:19000/config_dump?format=json" > test.json*.goldenin this PRsample intention
proxy-default to enable http mode
Links
todo