Add changelog entries for Consul 1.13.8 + 1.14.7#17399
Merged
nathancoleman merged 1 commit intomainfrom May 17, 2023
Merged
Conversation
nathancoleman
added
pr/no-changelog
jmurret
approved these changes
May 17, 2023
Member
jmurret
left a comment
jmurret
left a comment
There was a problem hiding this comment.
some minor grammar / consistency things. take or leave em.
|
|
||
| BUG FIXES: | ||
|
|
||
| * Fix an bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] |
Member
There was a problem hiding this comment.
Suggested change
| * Fix an bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] | |
| * Fix a bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] |
Member
Author
There was a problem hiding this comment.
I do find these useful but am hesitant to change them since CHANGELOG.md is generated from the files in .changelog, so the generated changelog then wouldn’t match the source
|
|
||
| * Fix an bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] | ||
| * acl: **(Enterprise only)** Check permissions in correct partition/namespace when resolving service in non-default partition/namespace | ||
| * acls: Fix ACL bug that can result in sidecar proxies having incorrect endpoints. |
Member
There was a problem hiding this comment.
Suggested change
| * acls: Fix ACL bug that can result in sidecar proxies having incorrect endpoints. | |
| * acl: Fix ACL bug that can result in sidecar proxies having incorrect endpoints. |
|
|
||
| BUG FIXES: | ||
|
|
||
| * Fix an bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] |
Member
There was a problem hiding this comment.
Suggested change
| * Fix an bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] | |
| * Fix a bug where decoding some Config structs with unset pointer fields could fail with `reflect: call of reflect.Value.Type on zero Value`. [[GH-17048](https://github.com/hashicorp/consul/issues/17048)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ports the changelog entries for yesterday's releases - Consul 1.13.8 and 1.14.7 - into
main.Testing & Reproduction steps
Links
PR Checklist