Conversation
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/config-entries/ingress-gateway.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/ingress-gateways-usage.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
im2nguyen
left a comment
There was a problem hiding this comment.
Looks good, a couple small nits, but pre-approving so you're not blocked from merging
I noticed you used <CodeBlock> instead of <CodeBlockConfig>, can you please change this before merging? Also, this is a nit, but newlines are inconsistent after headings and codefences, would be nice if we can be consistent with a single new line after each one
website/content/docs/connect/gateways/ingress-gateway/usage.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/usage.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/usage.mdx
Outdated
Show resolved
Hide resolved
im2nguyen
left a comment
There was a problem hiding this comment.
Looks good, a couple small nits, but pre-approving so you're not blocked from merging
I noticed you used <CodeBlock> instead of <CodeBlockConfig>, can you please change this before merging? Also, this is a nit, but newlines are inconsistent after headings and codefences, would be nice if we can be consistent with a single new line after each one
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
website/content/docs/connect/gateways/ingress-gateway/tls-external-service.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Description
This PR refactors the existing ingress gateway documentation into overview, usage, and configuration reference content types. We edited some content for clarity and so that it fit into the content type paradigm, but it is mostly unchanged. Please review for accuracy.
Preview pages:
PR Checklist