Merged
Conversation
pglass
added
pr/no-changelog
pglass
requested review from
a team,
eikenb and
johnlanda
and removed request for
a team
johnlanda
reviewed
May 15, 2023
Contributor
johnlanda
left a comment
johnlanda
left a comment
There was a problem hiding this comment.
Looks good. A couple of minor comments on names and then a question on what each of the agents created in the test are used for.
johnlanda
reviewed
May 15, 2023
added 2 commits
May 18, 2023 13:11
…-tproxy-integration-test
pglass
force-pushed
the
pglass/NET-3685/pmtls-tproxy-integration-test
branch
from
af75461 to
34dfa0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This builds on top of the tproxy integration test to validate the new permissive mTLS mode in Consul 1.16. When a service in permissive mTLS mode, incoming connections to the service's regular address/port are allowed through to the destination app.
This also fixes a config problem which meant the static-server was not actually running with tproxy enabled(!)
Testing & Reproduction steps
Links
#17035
PR Checklist