api: ensure empty locality field is not transmitted to Consul#17137
Merged
api: ensure empty locality field is not transmitted to Consul#17137
Conversation
hashi-derek
approved these changes
Apr 25, 2023
rboyer
added
pr/no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the current
apiclient is used for two endpoints (catalog register, peering) it sends a stray{... "Locality": "", ...}to a Consul server because the field is not markedomitempty.If this lands on an older Consul server or client it will reject the request completely because of the unknown field.
Regressed in : #16581