Conversation
github-actions
bot
added
the
theme/cli
jkirschner-hashicorp
previously requested changes
Apr 21, 2023
Contributor
jkirschner-hashicorp
left a comment
jkirschner-hashicorp
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
I have one important suggestion for improvement in the comments.
johnlanda
dismissed
jkirschner-hashicorp’s stale review
Addressed in most recent commit
Contributor
jkirschner-hashicorp
left a comment
jkirschner-hashicorp
left a comment
There was a problem hiding this comment.
LGTM from a PM/UX perspective. Someone from eng needs to give an eng review though (which shouldn't take long). I recommend selecting someone from the team or posting on our Slack channel asking for a review.
jkirschner-hashicorp
requested review from
a team and
skpratt
and removed request for
a team
Contributor
|
Looks like adding the I forget that it auto-selects a specific individual from the group. Handy! |
pglass
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When starting the consul agent, we output a status message which shows various parts of the configuration including
Gossip EncryptionandAuto-Encrypt-TLSconfigurations.This adds another field to the status showing whether or not ACLs are enabled.
Testing & Reproduction steps
PR Checklist