Conversation
banks
added
the
backport/1.15
github-actions
bot
added
the
pr/dependencies
dhiaayachi
approved these changes
Apr 21, 2023
loshz
approved these changes
Apr 21, 2023
banks
added a commit
that referenced
this pull request
Apr 21, 2023
* Bump raft to 1.5.0 * Add CHANGELOG entry * Go mod tidy
banks
added a commit
that referenced
this pull request
Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pulls in hashicorp/raft#541 which fixes a performance issue in our Raft implementation. See that PR for a very in-depth analysis of the issue and the change impacts.
Testing Considerations
The fix was tested extensively in Consul locally as part of the wal testing for 1.15. Results of that are given in the PR linked.
I'm going to backport to 1.15 since it should be easy to and will allow people testing WAL in 1.15 to reproduce our results without this performance anomaly without a major upgrade.
Links
PR Checklist
[ ] updated test coverage(not applicable)