Skip to content

Backport of Allow HCP metrics collection for Envoy proxies into release/1.15.x#16609

Closed
hc-github-team-consul-core wants to merge 5 commits intorelease/1.15.xfrom
backport/cc-4361/hcp-metrics-bootstrap-config/manually-composed-snail
Closed

Backport of Allow HCP metrics collection for Envoy proxies into release/1.15.x#16609
hc-github-team-consul-core wants to merge 5 commits intorelease/1.15.xfrom
backport/cc-4361/hcp-metrics-bootstrap-config/manually-composed-snail

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16511 to be assessed for backporting due to the inclusion of the label backport/1.15.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

Add a new envoy flag: envoy_hcp_metrics_bind_socket_dir, a directory where a unix socket will be created with the name <namespace>_<proxy_id>.sock to forward Envoy metrics.
If set, this will configure a local stats_sink and STATIC cluster to forward Envoy metrics to an HCP collector.

The HCP Cloud team is working on enabling observability metrics in HCP.

There will be a follow-up PR to generate a listener and cluster dynamically that will be listening on this unix socket.
That listener and cluster will be configured to route to collector instances through the service mesh.

Caveat: we needed to add this local listener indirection as a workaround due to this issue

Testing & Reproduction steps

  • Added unit tests
  • Tested locally by running consul, registering a proxy with the flag configured and starting Envoy with consul connect command.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/cc-4361/hcp-metrics-bootstrap-config/manually-composed-snail branch from 6138f5a to c0c205f Compare March 10, 2023 20:53
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified labels Mar 10, 2023
@freddygv
Copy link
Contributor

Closing in favor of #16611, since this auto-backport is incomplete

@freddygv freddygv closed this Mar 10, 2023
@github-actions github-actions bot deleted the backport/cc-4361/hcp-metrics-bootstrap-config/manually-composed-snail branch August 29, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants