Backport of Allow HCP metrics collection for Envoy proxies into release/1.15.x#16609
Closed
hc-github-team-consul-core wants to merge 5 commits intorelease/1.15.xfrom
Closed
Conversation
6138f5a to
c0c205f
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 10, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Contributor
|
Closing in favor of #16611, since this auto-backport is incomplete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16511 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
Add a new envoy flag:
envoy_hcp_metrics_bind_socket_dir, a directory where a unix socket will be created with the name<namespace>_<proxy_id>.sockto forward Envoy metrics.If set, this will configure a local
stats_sinkandSTATICcluster to forward Envoy metrics to an HCP collector.The HCP Cloud team is working on enabling observability metrics in HCP.
There will be a follow-up PR to generate a listener and cluster dynamically that will be listening on this unix socket.
That listener and cluster will be configured to route to collector instances through the service mesh.
Caveat: we needed to add this local listener indirection as a workaround due to this issue
Testing & Reproduction steps
PR Checklist
Overview of commits