NET-2904 Fixes API Gateway Route Service Weight Division Error#16531
Merged
missylbytes merged 10 commits intomainfrom Mar 6, 2023
Merged
NET-2904 Fixes API Gateway Route Service Weight Division Error#16531missylbytes merged 10 commits intomainfrom
missylbytes merged 10 commits intomainfrom
Conversation
missylbytes
commented
Mar 3, 2023
andrewstucki
reviewed
Mar 3, 2023
sarahalsmiller
approved these changes
Mar 3, 2023
Member
sarahalsmiller
left a comment
sarahalsmiller
left a comment
There was a problem hiding this comment.
Looks good to me, small nitpick, thanks for knocking this out so quickly
missylbytes
added
the
backport/1.15
andrewstucki
approved these changes
Mar 6, 2023
missylbytes
deleted the
net-2904-apigw-http-route-service-weight-division-error
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes HTTPRoutes with weights that don't divide evenly into 10000.
Previously, if a user created an HTTPRoute with services that had weights that did not divide evenly into 10000, (for example, two services, one with
weight=1and one withweight=2), they would never be registered properly so no traffic would go to them.Now the weights will be normalized.
Testing & Reproduction steps
Start consul with changes from branch
Use this gist to setup HTTPRoute services that have weights that do not divide evenly into 10000
Go to http://localhost:19000 , click on config-dump, and look at the
"dynamic_route_configs"to see the route weights adding up to 10000.Links
Fixes #16455
PR Checklist