Backport of Suppress AlreadyRegisteredError to fix test retries into release/1.15.x#16504
Merged
hc-github-team-consul-core merged 2 commits intorelease/1.15.xfrom Mar 2, 2023
Conversation
added 2 commits
March 2, 2023 14:55
hc-github-team-consul-core
force-pushed
the
backport/kisunji/fix-prometheus-metrics-registration/fully-rapid-tiger
branch
from
41562f6 to
18a8b0e
Compare
github-actions
bot
added
the
theme/internals
github-team-consul-core-pr-approver
approved these changes
Mar 2, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
hc-github-team-consul-core
deleted the
backport/kisunji/fix-prometheus-metrics-registration/fully-rapid-tiger
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16501 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
There is a new set of tests that have high rates of failure (example).
They are labelled "flaky" but in reality are failing deterministically whenever there is a test retry which causes TestAgents to initialize the prometheus collectors more than once in a single runtime.
This PR suppresses
prometheus.AlreadyRegisteredErrorso retries can run properly. This should have no impact on production usage as the metrics initialization happens only once on consul agent startup.Testing & Reproduction steps
metrics_test.golikeTestHTTPHandlers_AgentMetrics_WAL_Prometheuswith-count 2. Without this patch, the second run should always fail.PR Checklist
Overview of commits