Backport of Improve ux to help users avoid overwriting fields of ACL tokens, roles and policies into release/1.15.x#16489
Merged
hc-github-team-consul-core merged 8 commits intorelease/1.15.xfrom Mar 2, 2023
Conversation
0e1c08e to
e892647
Compare
5d8a711 to
74d0ff8
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 1, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16288 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
mergePoliciesfor deprecation and encouraging the use of-append-policy-idand-append-policy-nameto reduce the ambiguity when overwriting fields on update-policy-idand-policy-namewill overwrite existing policiesmergeRolesfor deprecation and encouraging the use of-append-role-idand-append-role-nameto reduce the ambiguity when overwriting fields on update-append-role-idand-append-role-namewill overwrite existing policiesTODO
-merge-rolesas we did for-merge-policiesTesting & Reproduction steps
Links
PR Checklist
Overview of commits