Backport of UI: Fix rendering issue in search and lists into release/1.15.x#16446
Merged
hc-github-team-consul-core merged 2 commits intorelease/1.15.xfrom Feb 27, 2023
Conversation
added 2 commits
February 27, 2023 22:00
b341e27 to
f3d992d
Compare
3ad3538 to
332711d
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 27, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16444 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Description
Fixes the issue that was reported here.
Search filters were throwing errors and showing up empty. This also resulted in lists not showing full results until being interacted with. Weirdly enough I haven't been able to reproduce this against mock data despite the helper still being called on strings.
Before:

Running locally I tried logging the properties being passed into the "search across" filter and then logging them with the
lowercasehelper. They show up locallyWhen running it on the built version the lowercase is never logged as it errors out (I had the errors filtered here)

After

List and filter shows up properly and the lowercase is logged (I didn't commit the logs)
Testing & Reproduction steps
1.15.0branchmake ui-dockerto build the ui imagemake dev-dockersetups/peeringdirectorydocker-compose upyarn setup:peeringsNow you can checkout this branch and repeat those steps to confirm the fix.
Links
CC-4383
#16429
PR Checklist
Overview of commits